PowerCLI/Powershell

Oh man! Ad-blocking software has been detected! :'(

This website is run by the community, for the community... and it needs advertisements in order to keep running. Blocking our ads means your killing our stats!
Please disable your ad-block, or become a premium member to hide all advertisements and this notice.

Afternoon chaps, wondering if someone could confirm if this bit of code would work in PowerCLI

Code:

function CreateSnapshot {
	param([string]$vmname)
	Get-VM $vmname | New-Snapshot -Name "Before Failover"
	$task = Get-Task | where {$_.Name -eq "CreateSnapshot_Task"}
	do {}
	While ($task -eq "Running")
}

Particularly the Do While block, what I'm aiming for is that it just waits until the $task is no longer in a running state.

Thanks

 

Oh man! Ad-blocking software has been detected! :'(

This website is run by the community, for the community... and it needs advertisements in order to keep running. Blocking our ads means your killing our stats!
Please disable your ad-block, or become a premium member to hide all advertisements and this notice.

Managed to test it and it seems to do what I expected but are still open to ideas if there is a correct way of doing it

 

My initial concern would be: How do you tell if the task is doing anything useful, or is in an infinite loop?
An infinite loop on the task would mean an infinite loop on your do/while.
You might want to add in some sort of time counter that will throw an error after X minutes.

 

Good thinking I suppose I could pull the task start time and check it in my do block and if it passes x hrs/mins then throw an exception

 

Is there an equivalent of the DOS shell "start /wait" in PowerShel - Vista Forums this link has a few ideas, I was searching for a ps equivalent of the batch start /wait post 5 looks promising with ones of the community extensions.

 

Cheers Chris

 

I use a similar system to reboot some of our mainframe print servers. It took me much googling to decide that knowing when a task is doing something useful is indistinguishable from when a task just running.

 

This is what I've got now

Code:

function CreateSnapshot {
	param([string]$vmname)
	Get-VM $vmname | New-Snapshot -Name "Before Failover"
	$task = Get-Task | where {$_.Name -eq "CreateSnapshot_Task"}
	$i = 0
	do {
	if ($i -ge 50) {
	Throw ("Snapshot timeout error")
	} else {
	$i++
	Sleep 3
	} While ($task -eq "Running")
}

 

Or of course you could just ask Mr Renouf to have a look ;)

 

I've emailed the big chap to see what he thinks